Use created at server timestamp #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the way we check for duplicated message to allow a 10s window with the same body rather than an exact match of timestamp. This is needed as the timestamp of the message pulled is now the one of the creation of the server, and not the same we have locally (sent at).
Mikunj
reviewed
Sep 4, 2020
Bilb
force-pushed
the
use-created-at-server-timestamp
branch
from
9bd7d27
to
76664d9
Compare
Mikunj
approved these changes
Sep 7, 2020
Mikunj
approved these changes
Sep 8, 2020
Mikunj
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order messages received by the server created_at timestamp rather than the one included in the message.
This is to prevent messages from a user with an out of sync clock to be able to sent message way in the past or in the future.
Also changes the way we check for duplicates. As we now rely on the server timestamp, we have a difference of timestamp between the message we sent, and the message the server sent us back on pull. This creates two messages on desktop. The way to fix it is to add a timeframe of 10s during a which, a message from a specific user and with the same content will be considered a duplicate, and so will be dropped