add notify to PN server on message sent #1346
Conversation
| const shouldNotifyPushServer = | ||
| hasBodyOrAttachments && | ||
| isSessionOrClosedMessage && | ||
| sentMessage.ttl === |
There was a problem hiding this comment.
We actually don't need this check now that we're checking for a body or attachments :)
There was a problem hiding this comment.
Oops. I matched the android way which was checking this field, https://github.com/loki-project/session-android-service/pull/84/files#diff-d6257378506ec22d884fbbb68f831aa2R29
I will fix it in a new PR
| @@ -1253,32 +1253,67 @@ | |||
| // if we did not sync or trigger a sync message for this specific message already | |||
| const shouldTriggerSyncMessage = | |||
| !isOurDevice && | |||
| !isOpenGroupMessage && | |||
There was a problem hiding this comment.
This doesn't matter right now as we're currently not doing any syncing, but in principle it's correct that open group messages aren't synced
There was a problem hiding this comment.
I removed it from here, because the whole sync block is now on the if excluding OpenGroupMessage at https://github.com/loki-project/session-desktop/pull/1346/files/3a876c7322c97bde8df9aaf74e3a3e067c781d8a#diff-fdb432d7888e10d18d02c7becd34c5e4R1309
notify the PN server on message sent, so that it triggers a push notifications to mobile devices