Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump contrast on attachment overlay text #2952

Merged
merged 7 commits into from
Oct 20, 2023

Conversation

KeeJef
Copy link
Collaborator

@KeeJef KeeJef commented Oct 9, 2023

This is a proxy pull request from the following codeberg repo, https://codeberg.org/gravel/session-desktop/commits/branch/more-images-count-visibility

When viewing a message with too many image attachments,
a preview of the remaining images is shown,
overlaid with an indicator of the remaining image count.

The indicator was, however, poorly visible on light image backgrounds.

This commit increases the text size of the indicator and includes
a drop shadow on the indicator text, thus improving the indicator's
readability.

Relates: to #2762

@Bilb
Copy link
Collaborator

Bilb commented Oct 15, 2023

Would be good to have a screenshot of how it looks after the change, but I'll give it a try locally.

@Bilb
Copy link
Collaborator

Bilb commented Oct 15, 2023

image
I am not sure this is going to be enough.
Can you force the background to be darker with something like this instead on the

[...]
 background-color: rgba(0, 0, 0, 0.7);

it looks like this
image
image

@Bilb
Copy link
Collaborator

Bilb commented Oct 16, 2023

will check with design team

Comment on lines 837 to 843
font-size: 30px;
font-weight: normal;
letter-spacing: 0;

text-align: center;
--text-shadow-offset: 0.05em;
text-shadow: var(--black-color) var(--text-shadow-offset) var(--text-shadow-offset) 0.15em;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: 30px;
font-weight: normal;
letter-spacing: 0;
text-align: center;
--text-shadow-offset: 0.05em;
text-shadow: var(--black-color) var(--text-shadow-offset) var(--text-shadow-offset) 0.15em;
font-size: 20px;
font-weight: normal;
letter-spacing: 0;
text-align: center;
background-color: rgba(0, 0, 0, 0.7);

@Bilb
Copy link
Collaborator

Bilb commented Oct 16, 2023

@KeeJef design said we want
background-color: rgba(0, 0, 0, 0.7);
no text-shadow
and font size back to 20xp. Can I let you update this PR or I make one on the side?

@KeeJef
Copy link
Collaborator Author

KeeJef commented Oct 16, 2023

I can update

@KeeJef
Copy link
Collaborator Author

KeeJef commented Oct 17, 2023

Updated

@Bilb Bilb changed the base branch from clearnet to unstable October 20, 2023 04:30
@Bilb
Copy link
Collaborator

Bilb commented Oct 20, 2023

lgtm

@Bilb Bilb merged commit d320fe5 into oxen-io:unstable Oct 20, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants