Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard shortcuts to modals #2977

Merged
merged 10 commits into from
Mar 28, 2024
Merged

Add keyboard shortcuts to modals #2977

merged 10 commits into from
Mar 28, 2024

Commits on Mar 21, 2024

  1. feat: make delete and backspace keys work the same as delete button

    @ianmacd @KeeJef
    ianmacd authored and KeeJef committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2274667 View commit details
    Browse the repository at this point in the history

  2. fix: enable use of escape on modals 

    feat: confirm modal when enter is pressed

fix: fix linter issues

fix: update rebase and fix lint issues

fix: remove duplicate code
    @KeeJef
    KeeJef committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    9b79080 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. fix: add checks to deal with non server deletable messages

    @Bilb
    Bilb committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    93211b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. feat: add focustrap for dialog and focus-within for buttons

    @Bilb
    Bilb committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    40a1bb4 View commit details
    Browse the repository at this point in the history

  2. fix: wrap radiobutton in buttons to focus is visible

    @Bilb
    Bilb committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3214786 View commit details
    Browse the repository at this point in the history

  3. fix: tab navigation in modals

    @Bilb
    Bilb committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ce1dfd2 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. fix: add focus trap to the selectionoverlay too

    @Bilb
    Bilb committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    dca7469 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'oxen/unstable' into delete-and-backspace

    @Bilb
    Bilb committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f7d574c View commit details
    Browse the repository at this point in the history

  3. fix: no need to handle Delete key in convo now 

    the focustrap on the selection overlay will grab the keys and do the
acitons when it is mounted
    @Bilb
    Bilb committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a52ed64 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. fix: minor ui fixes

    @Bilb
    Bilb committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    d267e7c View commit details
    Browse the repository at this point in the history