Add keyboard shortcuts to modals #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
requested changes
Mar 21, 2024
KeeJef
force-pushed
the
delete-and-backspace
branch
from
12fc3d6
to
504d989
Compare
Bilb
approved these changes
Mar 21, 2024
feat: confirm modal when enter is pressed fix: fix linter issues fix: update rebase and fix lint issues fix: remove duplicate code
KeeJef
force-pushed
the
delete-and-backspace
branch
from
504d989
to
9b79080
Compare
|
|
yougotwill
requested changes
Mar 21, 2024
yougotwill
requested changes
Mar 26, 2024
ts/components/conversation/header/ConversationHeaderSelectionOverlay.tsx
Outdated
Show resolved
Hide resolved
yougotwill
reviewed
Mar 26, 2024
Bilb
force-pushed
the
delete-and-backspace
branch
from
01b493a
to
ce1dfd2
Compare
4 tasks
the focustrap on the selection overlay will grab the keys and do the acitons when it is mounted
yougotwill
requested changes
Mar 27, 2024
ts/components/conversation/header/ConversationHeaderSelectionOverlay.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working off this PR #2281 which adds shortcuts for the 'Delete' and 'Backspace'
keys to delete a message when a user is in selection mode.
This PR extends additional keyboard shortcuts for modals created using the SessionConfirm dialog component, adding 'Escape' which will call the onClickCancelHandler to close the modal and 'Enter' which will call the onClickOkHandler. This should make navigating deletion dialogs easier.