forked from signalapp/Signal-Desktop
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disappearing messages v2 #3016
Merged
Merged
Disappearing messages v2 #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expireTimer on the model is in seconds so we need to convert it
signature now generates and renamed expire file to expireRequest
better logging and handle errors more smoothly
now just need to make sure to call both endpoints in the correct places
…pdates therefore we don't need to update the read status explicitly
we need the returned messageHash from the swarm
for now it will hit the expire endpoint twice
nested pRetry Abort errors can break our retry logic so we need to catch them
nested pRetry Abort errors can break our retry logic so we need to catch them
…onversationmodetype
this means convo has expirationMode and messages have expirationType
forgot to expire only unread disappearing messages and not all messages
…ppearingconversationmode
…ationdisappearingmode
before the v2 release
use the default mode and timer value for the convo type
useconversationusernameorshorten to usenicknameorprofilenameorshortenedpubkey
replaced all expirationMode calls
…re-message-information
carousel button padding
increased attachment preview size to alignment with other content
for delete button in more message info
used in delete message modal
now delete modal supports delete for me or everyone
pass yarn ready
rtl text support in panelbutton and panelradiobutton
we no longer need the back button
…ig_disappearingmessage
…fig_disappearingmessage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping this one (on oxen-io) so we can make PRs to it from other repository and still keep track of them
Notes copy pasted from #2940
Disappearing messages leave attachments on disk #2594, https://github.com/oxen-io/session-desktop/issues/