Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearing messages v2 #3016

Merged
merged 526 commits into from
Feb 4, 2024
Merged

Disappearing messages v2 #3016

merged 526 commits into from
Feb 4, 2024

Conversation

Bilb
Copy link
Collaborator

@Bilb Bilb commented Feb 2, 2024

Keeping this one (on oxen-io) so we can make PRs to it from other repository and still keep track of them

Notes copy pasted from #2940

  • Updated right panel in a conversation to use overlay logic similar to the left panel.
  • Improved design for disappearing messages
  • Added panel radio buttons that are used for the disappearing message timer options
  • Improved Conversation Header that can switch between the notification settings, disappearing message setting and group members. When you click on the heading it opens the related right panel option (if available)
  • Added 2 new disappearing message modes (The original mode aka. Legacy will be removed in the future but will be kept for backwards compatibility / migration purposes for now)
    • Disappear After Read
    • Disappear After Send
  • Added disappearing support to other visible messages (call, group update, media extraction notifications etc.)
  • Use clock svg for disappearing countdown in all cases to keep in line with other platforms.
  • Disappearing messages are now correctly deleted from the swarm and won't appear when restoring a device
  • Users with newer desktop clients will get notified if they are sent messages from an older (legacy) client encouraging them to tell the other user to upgrade
  • Attachments should be correctly deleted off disk (and off swarm) once deleted in the client (solves
    Disappearing messages leave attachments on disk #2594, https://github.com/oxen-io/session-desktop/issues/
  • Improved spacing and line height on toast notification
  • Disappearing Messages settings now sync via libsession with release v0.3.0
  • Fixed visual alignment all message types in message list and moved spacing to parent. This also fixes the alignment of hte disappearing messages timer for different message types
  • Unit Tests everywhere

expireTimer on the model is in seconds so we need to convert it
signature now generates and renamed expire file to expireRequest
better logging and handle errors more smoothly
now just need to make sure to call both endpoints in the correct places
…pdates

therefore we don't need to update the read status explicitly
we need the returned messageHash from the swarm
for now it will hit the expire endpoint twice
nested pRetry Abort errors can break our retry logic so we need to catch them
nested pRetry Abort errors can break our retry logic so we need to catch them
this means convo has expirationMode and messages have expirationType
forgot to expire only unread disappearing messages and not all messages
use the default mode and timer value for the convo type
useconversationusernameorshorten to usenicknameorprofilenameorshortenedpubkey
replaced all expirationMode calls
Bilb and others added 24 commits January 9, 2024 14:26
carousel button padding
increased attachment preview size to alignment with other content
for delete button in more message info
now delete modal supports delete for me or everyone
rtl text support in panelbutton and panelradiobutton
we no longer need the back button
@Bilb Bilb mentioned this pull request Feb 2, 2024
@Bilb Bilb merged commit ad9905d into unstable Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants