🚸 OSQPOptimizer -> OSQP.Optimizer #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstellato
approved these changes
Oct 14, 2018
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 86.28% 86.31% +0.02%
==========================================
Files 6 6
Lines 970 972 +2
==========================================
+ Hits 837 839 +2
Misses 133 133
Continue to review full report at Codecov.
|
mlubin
reviewed
Oct 14, 2018
| export OSQPOptimizer | ||
| function OSQPOptimizer() | ||
| Base.depwarn("OSQPOptimizer() is deprecated, use OSQP.Optimizer() instead.", | ||
| :OSQPOptimizer) |
There was a problem hiding this comment.
Shouldn't this function return Optimizer() to avoid breaking existing code?
There was a problem hiding this comment.
It does actually:
julia> using OSQP.MathOptInterfaceOSQP
[ Info: Precompiling OSQP [ab2f91bb-94b4-55e3-9ba0-7f65df51de79]
julia> optimizer = OSQPOptimizer()
┌ Warning: OSQPOptimizer() is deprecated, use OSQP.Optimizer() instead.
│ caller = top-level scope at none:0
└ @ Core none:0
Optimizer(OSQP.Model(Ptr{OSQP.Workspace} @0x0000000000000000, Float64[], Float64[]), false, OSQP.Results(Float64[], Float64[], OSQP.Info(140496452123152, #undef, 569348, 3, 1.5e-323, 0.0, 0.0, 0.0, 6.94145239783165e-310, 6.94144482996333e-310, 6.9414448298977e-310, 0, 0.0), Float64[], Float64[]), true, Dict{Symbol,Any}(), MinSense::OptimizationSense = 0, 0.0, Float64[], OSQP.MathOptInterfaceOSQP.ModificationCaches.ProblemModificationCache{Float64}(#undef, #undef, #undef, #undef, #undef), OSQP.MathOptInterfaceOSQP.ModificationCaches.WarmStartCache{Float64}(#undef, #undef), Dict{Int64,UnitRange{Int64}}())Note that this is actually exactly equivalent to
Base.@deprecate OSQPOptimizer() OSQP.Optimizer()No need to change this in this PR, just FYI.
There was a problem hiding this comment.
Ah, I hadn't noticed b52ad84.
There was a problem hiding this comment.
Forgot about this macro, @tkoolen thanks for the tip :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.