Move sp_update and rot_update to MgsCommon #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
commented
Apr 5, 2024
| @@ -26,7 +26,8 @@ use userlib::sys_get_timer; | |||
|
|
|||
| // How big does our shared update buffer need to be? Has to be able to handle SP | |||
| // update blocks for now, no other updateable components. | |||
| const UPDATE_BUFFER_SIZE: usize = SpUpdate::BLOCK_SIZE; | |||
| const UPDATE_BUFFER_SIZE: usize = | |||
There was a problem hiding this comment.
This is a drive-by fix to make UPDATE_BUFFER_SIZE more robust in case per-component block size ever diverges; mgs_gimlet.rs was already doing this.
mkeeter
commented
Apr 5, 2024
| @@ -42,7 +42,8 @@ userlib::task_slot!(TRANSCEIVERS, transceivers); | |||
|
|
|||
| // How big does our shared update buffer need to be? Has to be able to handle SP | |||
| // update blocks for now, no other updateable components. | |||
| const UPDATE_BUFFER_SIZE: usize = SpUpdate::BLOCK_SIZE; | |||
| const UPDATE_BUFFER_SIZE: usize = | |||
| usize_max(SpUpdate::BLOCK_SIZE, RotUpdate::BLOCK_SIZE); | |||
hawkw
approved these changes
Apr 5, 2024
jgallagher
approved these changes
Apr 5, 2024
mkeeter
force-pushed
the
move-update-to-common
branch
from
b80ed98
to
6b9817f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be convenient for #1707 if
MgsCommoncould check update state, so this PR moves theSpUpdateandRotUpdatemembers intoMgsCommon.