Fix almost all remaining warnings from the toolchain update. #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
reviewed
Apr 9, 2024
| return Err(e) | ||
| .map_err(MonorailError::from) | ||
| .map_err(RequestError::from); | ||
| return Err(RequestError::from(MonorailError::from(e))); |
There was a problem hiding this comment.
Clippy says to meet it behind the school at 3pm and, quote, "let's finish this"
mkeeter
approved these changes
Apr 9, 2024
cbiffle
force-pushed
the
cbiffle/warnings
branch
3 times, most recently
from
aa7be08
to
d8ab73d
Compare
hawkw
approved these changes
Apr 9, 2024
labbott
reviewed
Apr 11, 2024
| @@ -834,7 +834,7 @@ fn main() -> ! { | |||
| .load_bitstream(AUXFLASH.get_task_id()) | |||
| { | |||
| Err(e) => { | |||
| let code = u32::try_from(e).unwrap_lite(); | |||
There was a problem hiding this comment.
Everytime an unwrap gets removed a microcontroller gets its wings
Comment on lines
-49
to
-50
| sp_update: SpUpdate, | ||
| rot_update: RotUpdate, |
There was a problem hiding this comment.
Did those get folded into some default somewhere?
This only covers cases that appeared trivially correct on local inspection.
These are not actually unused, annoyingly.
All _new_ instances of this warning firing are false positives, and are suppressed in this commit.
Clippy would like us to automatically derive default for enums where possible instead of writing our own impl. I happen to agree with Clippy.
This adds Default impls where it seemed appropriate and/or easy to do so, and suppresses the warning in cases where it'd just be dead code generated to appease the clipster.
This adds Default impls where it seemed appropriate and/or easy to do so, and suppresses the warning in cases where it'd just be dead code generated to appease the clipster.
This is the only module that uses static mut and unsafe in a way that is not obviously correct. In the interest of preventing regressions everywhere _else,_ I'm suppressing the relevant warning for this module only.
cbiffle
force-pushed
the
cbiffle/warnings
branch
from
d8ab73d
to
63aa8cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes everything but Hiffy's use of unsafe (or anything anybody has added since I started on this branch).
This change turns Clippy back on to prevent regressions.