Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the filename properly #21

Closed
oxinabox opened this issue Jan 16, 2018 · 0 comments · Fixed by #22
Closed

Get the filename properly #21

oxinabox opened this issue Jan 16, 2018 · 0 comments · Fixed by #22

Comments

@oxinabox
Copy link
Owner

oxinabox commented Jan 16, 2018

Right now filenames are determined by using basename(remotepath)
Which is great for things like example.com/data.csv.

However, some data comes in the form example.com/data,
and then uses the content-disposition header element to say what the filename is.

Real example:
https://api.github.com/repos/JuliaCI/Coverage.jl/tarball

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant