=use HTTP.jl for name resolution #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=========================================
+ Coverage 55.89% 59.8% +3.91%
=========================================
Files 9 9
Lines 229 209 -20
=========================================
- Hits 128 125 -3
+ Misses 101 84 -17
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate solution to #21 , should be more cross-system happy than #22 though it adds a medium-weight dependency.
I think in the future,
it might be good to make file naming the responsibility of the
fetch_method,and then define a
downloadmethod using HTTP, that does this naming stuff using theGETheader-info.