Add DEFAULT_WORKSPACE path to git safe.directory by default #1770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1766
Adds git safe.directory DEFAULT_WORKSPACE by default in entrypoint.sh.
Proposed Changes
See discussion and motivation in #1766 .
Note: I made the option default, but left an small undocumented env variable to let anyone really wishing the old way configure it by setting WORKSPACE_AS_SAFE_DIR to "false". If you don't get any questions about this default behaviour over time, I would suggest to remove that flag. On the other hand, If you do get questions for anyone wishing this, let's document WORKSPACE_AS_SAFE_DIR properly and add it to the documentation.
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance
Signed-off-by: Josef Andersson josef.andersson@gmail.com