Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEFAULT_WORKSPACE path to git safe.directory by default #1770

Merged

Conversation

janderssonse
Copy link
Contributor

Fixes #1766

Adds git safe.directory DEFAULT_WORKSPACE by default in entrypoint.sh.

Proposed Changes

See discussion and motivation in #1766 .

Note: I made the option default, but left an small undocumented env variable to let anyone really wishing the old way configure it by setting WORKSPACE_AS_SAFE_DIR to "false". If you don't get any questions about this default behaviour over time, I would suggest to remove that flag. On the other hand, If you do get questions for anyone wishing this, let's document WORKSPACE_AS_SAFE_DIR properly and add it to the documentation.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Signed-off-by: Josef Andersson josef.andersson@gmail.com

Signed-off-by: Josef Andersson <josef.andersson@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1770 (f937e5b) into main (b5b7741) will increase coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
+ Coverage   83.51%   84.06%   +0.54%     
==========================================
  Files         160      160              
  Lines        4241     4241              
==========================================
+ Hits         3542     3565      +23     
+ Misses        699      676      -23     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.74% <0.00%> (+2.56%) ⬆️
...alinter/tests/test_megalinter/helpers/utilstest.py 89.01% <0.00%> (+8.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for your contribution :)

@nvuillam nvuillam merged commit f7ab207 into oxsecurity:main Aug 21, 2022
@janderssonse janderssonse deleted the feature/git-add-safe-default_workspace branch February 17, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants