Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of TERRAFORM_KICS_ARGUMENTS #1950

Merged
merged 8 commits into from
Oct 8, 2022
Merged

Fix use of TERRAFORM_KICS_ARGUMENTS #1950

merged 8 commits into from
Oct 8, 2022

Conversation

nvuillam
Copy link
Member

@nvuillam nvuillam commented Oct 8, 2022

Fixes #1947

@nvuillam
Copy link
Member Author

nvuillam commented Oct 8, 2022

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.03s
✅ BASH shellcheck 7 0 0.29s
✅ BASH shfmt 7 0 0 0.33s
✅ COPYPASTE jscpd yes no 2.03s
✅ DOCKERFILE hadolint 105 0 8.38s
✅ JSON eslint-plugin-jsonc 21 0 0 2.39s
✅ JSON jsonlint 19 0 0.23s
✅ JSON v8r 21 0 16.47s
⚠️ MARKDOWN markdownlint 294 0 5 5.93s
✅ MARKDOWN markdown-link-check 294 0 5.55s
✅ MARKDOWN markdown-table-formatter 294 0 0 7.98s
✅ OPENAPI spectral 1 0 0.88s
⚠️ PYTHON bandit 170 55 2.72s
✅ PYTHON black 170 0 0 4.29s
✅ PYTHON flake8 170 0 2.08s
✅ PYTHON isort 170 0 0 0.79s
✅ PYTHON mypy 170 0 7.87s
✅ PYTHON pylint 170 0 12.31s
⚠️ PYTHON pyright 170 274 17.92s
✅ REPOSITORY checkov yes no 28.75s
✅ REPOSITORY git_diff yes no 0.29s
✅ REPOSITORY secretlint yes no 8.92s
✅ REPOSITORY trivy yes no 23.31s
✅ SPELL cspell 706 0 18.31s
✅ SPELL misspell 533 0 0 0.82s
✅ XML xmllint 3 0 0.0s
✅ YAML prettier 80 0 0 3.27s
✅ YAML v8r 22 0 45.23s
✅ YAML yamllint 81 0 1.39s

See errors details in artifact MegaLinter reports on CI Job page

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Merging #1950 (3c0509c) into main (1708e04) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1950      +/-   ##
==========================================
+ Coverage   82.68%   82.71%   +0.02%     
==========================================
  Files         157      157              
  Lines        3384     3384              
==========================================
+ Hits         2798     2799       +1     
+ Misses        586      585       -1     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.74% <0.00%> (+2.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nvuillam
Copy link
Member Author

nvuillam commented Oct 8, 2022

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.01s
✅ BASH shellcheck 7 0 0.26s
✅ BASH shfmt 7 0 0 0.03s
✅ COPYPASTE jscpd yes no 1.85s
✅ DOCKERFILE hadolint 105 0 7.86s
✅ JSON eslint-plugin-jsonc 21 0 0 1.74s
✅ JSON jsonlint 19 0 0.18s
✅ JSON v8r 21 0 15.66s
⚠️ MARKDOWN markdownlint 294 2 5 4.59s
✅ MARKDOWN markdown-link-check 294 0 4.95s
✅ MARKDOWN markdown-table-formatter 294 2 0 5.36s
✅ OPENAPI spectral 1 0 0.74s
⚠️ PYTHON bandit 170 55 2.35s
✅ PYTHON black 170 0 0 3.4s
✅ PYTHON flake8 170 0 2.09s
✅ PYTHON isort 170 0 0 0.38s
✅ PYTHON mypy 170 0 6.81s
✅ PYTHON pylint 170 0 10.28s
⚠️ PYTHON pyright 170 272 15.67s
✅ REPOSITORY checkov yes no 24.55s
⚠️ REPOSITORY devskim yes 59 1.1s
✅ REPOSITORY dustilock yes no 2.36s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 3.16s
✅ REPOSITORY syft yes no 2.46s
✅ REPOSITORY trivy yes no 17.06s
✅ SPELL cspell 706 0 16.06s
✅ SPELL misspell 533 2 0 0.41s
✅ XML xmllint 3 0 0.01s
✅ YAML prettier 80 0 0 2.4s
✅ YAML v8r 22 0 39.3s
✅ YAML yamllint 81 0 1.4s

See errors details in artifact MegaLinter reports on CI Job page

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit 66b5c3d into main Oct 8, 2022
@nvuillam nvuillam deleted the fixes/kics-args branch October 8, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying TERRAFORM_KICS_ARGUMENTS breaks kics
2 participants