Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureCommentReporter vars reflect official Azure DevOps naming #2510

Merged
merged 8 commits into from Apr 2, 2023
Merged

AzureCommentReporter vars reflect official Azure DevOps naming #2510

merged 8 commits into from Apr 2, 2023

Conversation

DariuszPorowski
Copy link
Contributor

Fixes #2509

Proposed Changes

  1. Changed vars naming in AzureCommentReporter vars to reflects official Azure DevOps naming convention
  2. Updated docs with Azure Pipelines usage scenario with passing build agent env vars - it eliminates explicite passing vars one-by-one (except SYSTEM_ACCESSTOKEN - it requires to be pass explicitly) and gives opportunity to work with ADO agent vars in the future.
    • the rest env vars can be pure megalinter envs, it increases cleanness in the pipeline
  3. Using old BUILD_BUILD_ID as fallback to keep backward compatibility
  4. Not planned, but came up while working on it this fix: updated outdated ToC in main README + minor linting

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@DariuszPorowski DariuszPorowski marked this pull request as ready for review April 1, 2023 21:24
@nvuillam
Copy link
Member

nvuillam commented Apr 1, 2023

@DariuszPorowski Great initiative that will reduce the size of the Azure pipeline script, many thanks :)

As you seem to know Azure a lot, do you recommend a python package to call Azure API ?

I'd like to enhance azure integration by removing the previous MegaLinter threads on PRs when posting a new one, and calling directly with http does not feel easy to maintain

@DariuszPorowski
Copy link
Contributor Author

DariuszPorowski commented Apr 1, 2023

hi @nvuillam the only what I know, and its official is https://github.com/microsoft/azure-devops-python-api (Azure DevOps) it's like wrapper-style sdk for rest. Official sdk for Azure Cloud is https://github.com/Azure/azure-sdk-for-python but this one does not include Azure DevOps stuff as I know.
I feel confident in Azure, working with it almost from the beginning. Feel free to reach out me if you have any questions.

@nvuillam
Copy link
Member

nvuillam commented Apr 1, 2023

Thanks, I'll use it in a future PR :)

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great quality PR, but plz check comments to make a tiny fix before we can merge :)

README.md Show resolved Hide resolved
docs/installation.md Show resolved Hide resolved
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great great PR :)

@nvuillam nvuillam merged commit 588a192 into oxsecurity:main Apr 2, 2023
7 checks passed
@DariuszPorowski DariuszPorowski deleted the 2509-azdevops-buildid branch April 2, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(AzureCommentReporter) BUILD_BUILD_ID is not official Azure DevOps env var
2 participants