add kotlin-detekt linter

[enciyo]

Add detekt kotlin lint
#1179

Add new linter on kotlin.megalinter-decriptor.yml

[echoix]

Apart from that, looks pretty much ok!

[nvuillam]

/build

Command run output
Build command workflow started.
Installing dependencies
Running script ./build.sh
Build command workflow completed updating files.

[nvuillam]

I allowed myself to apply a fix directly on your branch :)
But a new build is required ^^

[enciyo]

I apologize for forgetting, I have started a new build.sh and pushed it. Thank you :)

[nvuillam]

0.997   inflating: pmd-bin-6.55.0/lib/pmd-ui-6.49.0.jar
0.997   inflating: pmd-bin-6.55.0/lib/pmd-visualforce-6.55.0.jar
2.116 Archive:  detekt-cli-1.23.3.zip
2.737    creating: detekt-cli-1.23.3/
2.737    creating: detekt-cli-1.23.3/lib/
2.737   inflating: detekt-cli-1.23.3/lib/detekt-cli-1.23.3-all.jar
2.737    creating: detekt-cli-1.23.3/bin/
2.737   inflating: detekt-cli-1.23.3/bin/detekt-cli.bat
2.737   inflating: detekt-cli-1.23.3/bin/detekt-cli
2.739 chmod: /usr/bin/detekt-cli: No such file or directory

it seems that the installation instructions don't work ^^

[enciyo]

I will fix this and resubmit it in due time.

[enciyo]

Also I tested with below script on Docker

docker buildx build -f linters/kotlin_detekt/Dockerfile . --tag kotlin_detekt && \
TEST_KEYWORDS_TO_USE="kotlin_detekt" && \
docker run -e TEST_CASE_RUN=true -e  OUTPUT_DETAIL=detailed -e TEST_KEYWORDS="${TEST_KEYWORDS_TO_USE}" -e MEGALINTER_VOLUME_ROOT="." -v "/var/run/docker.sock:/var/run/docker.sock:rw" -v $(pwd):/tmp/lint kotlin_detekt

And all test passed :)

[nvuillam]

@enciyo CI is good (lychee is boring just because of a dead URL), but why removing the SARIF management and forcing HTML ?

Such options should be enforced in .mega-linter.yml file, not the default option (that should be console output ^^ )

    cli_lint_extra_args:
      - --report
      - html:{{REPORT_FOLDER}}/kotlin_detekt_result.html
      - -i

[enciyo]

Detect doesn't support sarif in console output. Even if we use "--report sarif:{{SARIF_OUTPUT_FILE}}" it does not print as sarif on the console. That's why I had to remove sarif management.

Detekt does not produce any output file by default. It only has console output. I'm not sure whether there should be an output file here or not. I'm open to suggestions on this

[echoix]

@nvuillam Why is Kotlin included in so many flavors? Like go and Python?

[nvuillam]

@echoix because Kotlin can be used in some CICD workflow pipelines definition... I don't remember which one... Bamboo or TeamCity maybe

[echoix]

I reread the top of the file, it is mentionned TeamCity. It's kind of weird for me, from an external point of view

[nvuillam]

@echoix as any kind of repo can be used on TeamCity, I assumed that Kotlin workflows should be linted :/