Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify multi-line text alignment on all the platforms #1554

Open
3 of 5 tasks
Jonarw opened this issue May 10, 2020 · 1 comment
Open
3 of 5 tasks

Unify multi-line text alignment on all the platforms #1554

Jonarw opened this issue May 10, 2020 · 1 comment

Comments

@Jonarw
Copy link
Member

Jonarw commented May 10, 2020

Benchmark should be the 'Rendering Capabilities > Multi-line Alignment' and 'Rendering Capabilities > Multi-line Alignment/Rotation' examples.

  • WPF - fix horizontal alignment
    image

  • Windows Forms (and Core.Drawing) - fix horizontal alignment
    image

  • SkiaSharp
    image

  • ImageSharp - fixed in Improve ImageSharp.ImageRenderContext text alignment #1553
    image

  • SVG
    image

  • OxyPlot.PdfExporter - multiline text is not supported. Given we want to mark this as obsolete anyway, we don't have to worry about this too much I think
    image

  • OxyPlot.Pdf.PdfExporter - multiline text is not supported. Given we want to mark this as obsolete anyway, we don't have to worry about this too much I think
    image

@VisualMelon
Copy link
Contributor

If we reach a happy conclusion with #1551, then the code for performing this layout task could be provided by RenderContextBase. Adjustments will need to be made by the different platforms to account for the different rendering APIs (e.g. OxyPlot.Svg can only render relative to baseline), but this could reduce the individual complexity of each renderer, and generally make the code tidier.

If I can sit down for more than a few minutes I'll try to put a version of this together for OxyPlot.Svg implementation, which really needs #1551 to make sense at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants