Links to issues in CHANGELOG.md #1815
Conversation
Lette
force-pushed
the
links-in-changelog
branch
from
2feb559
to
c0c6874
Compare
|
Links are certainly nice! In-line links might be preferable to keep changes simple. In any case, I won't merge this myself, but I certainly don't object to the changes. |
|
I considered inline links but went the other way because the same issues are referenced in multiple places... I can easily change to inline if you want to. |
|
What does the markdown lint file achieve? On reflection, I think separating the links out would be better; it'll be a little more effort for contributors and maintainers, but it'll keep the content uncluttered. I'm not sure how this will work when it is merged, so I'll hang-fire on that for the moment (but otherwise approved). |
|
This PR came up in the discussion in #2012. Initially the links seemed like a nice idea to me. However, after thinking a bit more about it, I am not so sure anymore whether the comfort of these links outweighs the added maintenance effort. I don't have a strong opinion either way, probably leaning a bit against it. From what I understand from #2012, you were also a bit skeptical of this @VisualMelon? |
|
@Jonarw From memory I thought I was more opposed to this than it seems I actually was, or indeed am now that I've looked at this properly again. Like you, I'm happy either way, but would probably lean towards leaving things as-is so this isn't another thing that contributors have to worry about. |
|
Yes, agreed, so I will close this for now. Thanks anyway @Lette! |
Checklist
Changes proposed in this pull request:
If you think it's good, keep it. If not, no argument from me.
Thank you for this awesome library!
@oxyplot/admins