Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

changed onReady logic to wait for interactive state instead of complete #242

Closed
wants to merge 1 commit into from

Conversation

struys
Copy link

@struys struys commented Nov 22, 2013

It seems unnecessary to wait for complete. As far as I can tell, interactive state should be sufficient for anything easyxdm does.

@oyvindkinsey
Copy link
Owner

In IE, the readystate can become interactive if you're synchronously loading the script in the header, at which point the body does not yet exist. So if you want to support interactive, you'll have to exclude IE from this.

@struys
Copy link
Author

struys commented Nov 22, 2013

Man, that sucks.

Instead of specifically looking for IE, would it be acceptable to add a document.body check if we detect interactive state?

@oyvindkinsey
Copy link
Owner

Closing this for now. Please feel free to reopen if there's a more targeted fix in place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants