This repository has been archived by the owner on Nov 11, 2018. It is now read-only.
bash script improvements #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +58,10 @@ PS1=$PS1$(final_term_control_sequence 'B') | |||
| # Logic for terminal commands | |||
|
|
|||
| function trim() { | |||
| echo "$1" | sed -e 's/^ *//g' -e 's/ *$//g' | |||
| local var=$1 | |||
There was a problem hiding this comment.
This should be indented; also, str or text would be a more idiomatic identifier than var IMO
- bash_startup improvements (seeing a performance improvement of about
36ms in parsing the default.ftcommands, also removes external calls to
sed)
- use parameter substitution instead of splitting with the IFS when
reading default.ftcommands
- escape quotes using parameter substitution instead of sed
- replace sed in trim with parameter substitution
|
updated to address feedback. |
|
Merged! Thank you for your work. I have added your name to the about dialog credits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
36ms in parsing the default.ftcommands, also removes external calls to
sed)
reading default.ftcommands