Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radio effects #27

Closed
IvanScheers opened this issue Mar 27, 2024 · 11 comments
Closed

radio effects #27

IvanScheers opened this issue Mar 27, 2024 · 11 comments

Comments

@IvanScheers
Copy link

IvanScheers commented Mar 27, 2024 •
edited

Hi,

Not really an issue, but maybe an idea for taking wsay to the next level.

I'm working on a voice addon for a space sim. I coded a SAPI TTS to wav in Nim (nim-lang.org) and was relying on sox (Swiss Army Knife of Audio Processins) to play it. In my research to port my SAPI TTS code to c++, I stumbled upon wsay. My God, it does more than I expected and some more ;-).

fxradio
However, I believe the --fxradio could do with enhancement. Radio comms effect is more than distortion and noise, actually I think it's more about which frequencies of the voice are passed. I use a bandpass filter to alter the voice itself, to give it a more tinny character. That is what mainly happens, remember talking on an old phone (I'm old enough... alas). So I'd like to request to use --fxrado 7 8 9 (unused now) to just use 3 different bandpass filters, to get different radio qualities. Maybe chuck the noise you use for 1 - 6 and add a switch --noise, so the user can determine voice quality and noise level... The interference you introduced in the voice itself is excellent. However, most if not all developers of sim audio addons are bright enough to use an audio channel for radio static noise.

I don't imply you didn't do a magnificent job, if it feels like that I apologize. I just think you've made a great piece of software, that will become better and better.

pitch
While I'm at it, it's awesome wsay detected every voice available. I added voices in the past with a hack, but every time Windows did an update, the extra voices disappeared. Your wsay found them all ! However, because Microsoft always chucked them when updating, I used pitch and speed to differentiate and mimic more speakers. The same voice can sound quite different if one plays with speed and pitch. So implementing pitch in addition to speed (which is available in wsay), people with only a handful of voices on their system could tweak them to have 'virtually' more.

You've made an awesome tool : thank you !
@p-groarke
Copy link
Owner

p-groarke commented Mar 28, 2024 •
edited

Hi @IvanScheers , glad you find it useful.

First the easy answer : --pitch, yes. Unless there's some sort of technical blocker I'll add it next time I update.

Yes I intended to add bandpass to radiofx all along. I simply had way too much going on with 1.6 so I stopped where I'm at (distortion + sampling rate reduction (with folding) + bitcrushing + white noise). I definitely plan on adding bandpass to the system (might experiment with notch filters as well). That's why the--fxradio option use numbers, so I can easily add more without changing old effects.

However, I want to make it clear radio is really just for fun. I won't be doing full-on fancy HF/RF simulation stuff. I'll probably add a few more effects next time I play with wsay and call it a day.

I didn't think about noise being redundant, so thanks for mentioning. I don't want to complicate things by adding even more options, but I'll make sure there's a good selection of effects without whitenoise 👍 I just realized you are probably using the lib 🤣 I think you are the first person to do so! I'll definitely add a noise param then, I'll also keep it mind when creating new effects.

Take care, no promises on if and when any of this ships of course ;)

@IvanScheers
Copy link
Author

IvanScheers commented Mar 28, 2024 via email

@p-groarke
Copy link
Owner

@IvanScheers 1.6.1 is out with --pitch.

@IvanScheers
Copy link
Author

Thanks a lot !

I'm opening up another issue I encountered today while implementing to use wsay.exe in my project.

@p-groarke
Copy link
Owner

@IvanScheers Hey Ivan, here's a custom build of the next version. It has --fxradio_nonoise to disable whitenoise. No band-pass fancyness though ;)

Take care, hope this integrates better with your scenario.

wsay-v1.6.2-prerelease.zip

@IvanScheers
Copy link
Author

IvanScheers commented Apr 9, 2024 via email

@p-groarke
Copy link
Owner

@IvanScheers 1.6.2 has been released with both nonoise and filters on the effects pre-existing effects (as originally intended).

Your project sounds cool, hope this helps. Good day!

@IvanScheers
Copy link
Author

IvanScheers commented Apr 16, 2024 via email

@IvanScheers
Copy link
Author

IvanScheers commented May 11, 2024 via email

@p-groarke
Copy link
Owner

@IvanScheers Haha yes I'm french canadian :)

Looks like a bug with the audio device detection, thx for reporting it! I'm a bit busy these days, I'll get to it as soon as I can. In the meantime, you could try -p all to bypass this detection of your audio device. Or specify the audio device manually in -p.

I moved your report to a new issue to track it : #32

Might ping you for more details if I can't repro, cheers!

@IvanScheers
Copy link
Author

IvanScheers commented May 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p-groarke @IvanScheers