Encode size_t types with fixed-length + extended generated tests #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-ranav
reviewed
Jun 5, 2024
| // encode size_t as fixed 4-bytes integer | ||
| template <options O, typename T, typename U> | ||
| typename std::enable_if< | ||
| std::is_same_v<U, std::size_t>, |
There was a problem hiding this comment.
Should this be just size_t instead of std::size_t? To be consistent with the rest of your code in from_bytes.h
p-ranav
reviewed
Jun 5, 2024
include/alpaca/detail/to_bytes.h
Outdated
Comment on lines
106
to
124
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
|
Found additional issues, need to rethink on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #43 by serializing size_t integers (when fixed-length encoding is enabled) using a fixed and configurable number of bytes (32 or 64).
The current implementation is not architecture-agnostic.
The type used for size_t serialization can be configured in include/alpaca/detail/from_bytes.h by changing the using size_t_serialized_type = uint64_t; definition.
I also added a set of end-to-end tests (serialize + deserialize in the same test) generated by Chat-GPT.