Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: expand ternary operator in function call for compatibility #335

Merged
merged 1 commit into from
Nov 28, 2020

Conversation

ueno
Copy link
Member

@ueno ueno commented Nov 27, 2020

While the minimum version requirement of meson is 0.49, the current meson.build causes the parser to crash, because of the use of the ternary operator inside a function call:
mesonbuild/meson#5003

While the minimum version requirement of meson is 0.49, the current
meson.build causes the parser crash, because of the use of a ternary
operator inside a function call:
mesonbuild/meson#5003
@ueno
Copy link
Member Author

ueno commented Nov 27, 2020

cc @t184256 @Jakuje

Copy link
Contributor

@t184256 t184256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks, now I understand what you were leading to in that other discussion.

I can confirm that this patch fixes the Linux build using meson 0.49.2.

@ueno
Copy link
Member Author

ueno commented Nov 28, 2020

Thanks for checking.

@ueno ueno merged commit e1899c4 into p11-glue:master Nov 28, 2020
@Jakuje
Copy link
Contributor

Jakuje commented Nov 30, 2020

Thanks for looking into that!

@ueno ueno added this to the 0.23.22 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants