Add --provider option to p11-kit commands
#611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ueno
force-pushed
the
wip/dueno/module
branch
3 times, most recently
from
e15ef90
to
7ca8016
Compare
ueno
force-pushed
the
wip/dueno/module
branch
3 times, most recently
from
49fb56e
to
a0804a1
Compare
As the interface provided by tool.h is sorely for command-line option parsing, options.h would be a better name. This also allows consumers (the p11-kit and trust commands) to factor out shared utilities under the name of p11-kit/tool.[ch] or trust/tool.[ch]. Signed-off-by: Daiki Ueno <ueno@gnu.org>
This moves the common module loading and iteration logic to p11-kit/tool.c to avoid code duplication. Signed-off-by: Daiki Ueno <ueno@gnu.org>
Signed-off-by: Daiki Ueno <ueno@gnu.org>
ueno
force-pushed
the
wip/dueno/module
branch
from
a0804a1
to
0bcce00
Compare
ZoltanFridrich
approved these changes
Jan 2, 2024
Signed-off-by: Daiki Ueno <ueno@gnu.org>
This adds --provider option to p11-kit subcommands which loads PKCS#11 modules. The option would be useful for testing a specific module without installing it on the system. Signed-off-by: Daiki Ueno <ueno@gnu.org>
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #573