pypi2deb enhancements #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary as profiles/dpt/hooks/post is running `pristine-tar` from within the source package directory referring to `..` for the orig tarball, which is not present, because we unpacked it from its original location.
|
i think that's all i have for now |
this is useful when PyPI doesnt have the latest version or you're packaging a version that's not the latest for whatever reason
this is because debianize._render_template() wont replace a file if it's already present, that means if upstream already ships a debian/ directory, we wont replace its content with our template files. it's also the default behavior of other tools to just remove debian/ from an upstream tarball.
This enhancement allows users to fetch the upstream tarball from GitHub instead of PyPI. There are several advantages with using GH over PyPI: - oftentimes, upstreams dont release all the files really necessary for debian packaging (think of tests, doc source files, other artifacts like tests datafiles, etc) - PyPI may not be up to date, but if a project is hosted on GitHub, chances are it is properly tagged (or you can ask for a tag to be added) and so a tarball is available. py2dsp now has --github/--gh cli options to let you specify a GH URL (just the top-level project URL is needed); additionally, if the upstream project name (the last part of the URL) is not what you want to use, just add an additional argument to the command-line and it'll be used as the project name.
|
@p1otr i'm continuing with my enhancements (at least that's what i need the tool to do), but i think the most important change is now the ability to fetch the tarball from github instead of pypi |
…t msg and d/changelog)
prevents the package from being built twice, which doesnt play well with PEP517 backends & debian support Addresses: p1otr#30
This otherwise raises the following lintian warning by default: https://lintian.debian.org/tags/rules-do-not-require-root We should assume that packages do not need d/rules to be run as root by default, as this should be rare for Python software.
The copyright symbol used in the file provides no value and could lead to display errors on systems that have a poor unicode support. Just using the dates and the names of the copyright holders should be enough.
…k upstream branches
debian: update debhelper from v9 to v13
control.tpl: add Rules-Requires-Root: no
debianize.py: remove copyright symbol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to keep pushing to this PR with the changes i have in mind