End-to-end publishEntry tests #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #167 +/- ##
===============================================
+ Coverage 89.34% 89.97% +0.63%
===============================================
Files 43 43
Lines 2486 2633 +147
===============================================
+ Hits 2221 2369 +148
+ Misses 265 264 -1
Continue to review full report at Codecov.
|
sandreae
commented
Jun 18, 2022
cafca
reviewed
Jun 20, 2022
Comment on lines
+348
to
+360
| #[case::should_not_include_skiplink( | ||
| &entry_signed_encoded_unvalidated( | ||
| 14, | ||
| 1, | ||
| Some(DEFAULT_HASH.parse().unwrap()), | ||
| Some(DEFAULT_HASH.parse().unwrap()), | ||
| Some(Operation::from(&OperationEncoded::new(OPERATION_ENCODED).unwrap())) | ||
| , | ||
| key_pair(DEFAULT_PRIVATE_KEY) | ||
| ), | ||
| OPERATION_ENCODED, | ||
| "Could not decode payload hash DecodeError" | ||
| )] |
There was a problem hiding this comment.
Note: Example for error handling discussion
adzialocha
approved these changes
Jun 23, 2022
|
|
||
| let response = response.json::<serde_json::Value>().await; | ||
|
|
||
| // TODO: I think we'd like a nicer error message here. |
There was a problem hiding this comment.
I'd link to this issue here: #159
adzialocha
added a commit
that referenced
this pull request
Jun 23, 2022
* development: End-to-end publishEntry tests (#167)
adzialocha
added a commit
that referenced
this pull request
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-to-end tests (including many failing cases) for publishing entries.
This PR throws up a fewTODOs as I find some panicking cases. I suggest not fixing them in this PR but instead raising issues.Probably worth waiting for this: p2panda/p2panda#367 then we can introduce tests for these new errors and more invalid encoded entries as well.Targeting p2panda-rs branch which fixes
EntrySignedvalidation: https://github.com/p2panda/p2panda/tree/improve-validation-in-entry-signedFollow-up issues: #160 #159
p2panda-rsand then switch target branch back tomain📋 Checklist
CHANGELOG.md