Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSERT documents #173

Merged
merged 8 commits into from
Jun 27, 2022
Merged

UPSERT documents #173

merged 8 commits into from
Jun 27, 2022

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jun 27, 2022 •
edited

Following this bug: #172

We realised the SQL we have is not updating documents, only inserting.... So this is a fix for that and additional tests in the reduce task and DocumentStore.

馃搵 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@sandreae sandreae changed the base branch from main to postgres-ci June 27, 2022 13:24
@sandreae sandreae linked an issue Jun 27, 2022 that may be closed by this pull request
Critical error from reduce task when updating a Document #172
Closed
@codecov
Copy link

codecov bot commented Jun 27, 2022 •
edited

Codecov Report

Merging #173 (587087f) into development (c5123aa) will increase coverage by 2.23%.
The diff coverage is 97.54%.

@@               Coverage Diff               @@
##           development     #173      +/-   ##
===============================================
+ Coverage        88.60%   90.83%   +2.23%     
===============================================
  Files               42       43       +1     
  Lines             2202     2860     +658     
===============================================
+ Hits              1951     2598     +647     
- Misses             251      262      +11
Impacted Files Coverage 螖
aquadoggo/src/bin/dump_gql_schema.rs 0.00% <0.00%> (酶)
aquadoggo/src/config.rs 6.25% <酶> (酶)
aquadoggo/src/context.rs 100.00% <酶> (+25.00%) 猬嗭笍
aquadoggo/src/db/mod.rs 83.33% <酶> (-1.29%) 猬囷笍
aquadoggo/src/db/provider.rs 87.50% <酶> (酶)
aquadoggo/src/graphql/replication/log_id.rs 83.33% <酶> (酶)
aquadoggo/src/graphql/replication/mod.rs 68.23% <酶> (-0.37%) 猬囷笍
...rc/graphql/replication/single_entry_and_payload.rs 0.00% <0.00%> (酶)
aquadoggo/src/http/api.rs 50.00% <酶> (酶)
aquadoggo/src/materializer/input.rs 100.00% <酶> (+100.00%) 猬嗭笍
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ab8d186...587087f. Read the comment docs.

@sandreae sandreae marked this pull request as ready for review June 27, 2022 14:07
@adzialocha adzialocha changed the base branch from postgres-ci to development June 27, 2022 14:24
@adzialocha adzialocha self-requested a review June 27, 2022 14:31
adzialocha
adzialocha approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@adzialocha adzialocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挜

@adzialocha adzialocha merged commit e2a5e2e into development Jun 27, 2022
adzialocha added a commit that referenced this pull request Jun 27, 2022
@adzialocha
Merge branch 'main' into graphql-replication-client
367389b 
* main:
  Update README.md
  UPSERT documents (#173)
  Run tests against PostgreSQL, fix compatibility (#170)
  End-to-end publishEntry tests (#167)
  Reschedule pending tasks during startup (#168)
adzialocha added a commit that referenced this pull request Jun 27, 2022
@adzialocha
Merge branch 'main' into graphql-document-query-experimental
62ea4ba 
* main:
  Update README.md
  UPSERT documents (#173)
  Run tests against PostgreSQL, fix compatibility (#170)
  End-to-end publishEntry tests (#167)
adzialocha added a commit that referenced this pull request Jun 27, 2022
@adzialocha
Merge branch 'main' into schema-provider
b6ec8d6 
* main:
  Update README.md
  UPSERT documents (#173)
  Run tests against PostgreSQL, fix compatibility (#170)
  End-to-end publishEntry tests (#167)
@adzialocha adzialocha deleted the fix-for-updating-documents branch June 29, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adzialocha adzialocha adzialocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Critical error from reduce task when updating a Document
2 participants
@sandreae @adzialocha