Refactor replication API #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 90.58% 93.60% +3.01%
==========================================
Files 43 42 -1
Lines 2986 3142 +156
==========================================
+ Hits 2705 2941 +236
+ Misses 281 201 -80
Continue to review full report at Codecov.
|
This was
linked to
issues
Jul 1, 2022
Closed
adzialocha
force-pushed
the
refactor-replication-api
branch
from
7ac6ab4
to
aa89e56
Compare
sandreae
approved these changes
Jul 1, 2022
| .map(|entry_and_operation| { | ||
| // Unwrap as the entry was already validated before it entered the database | ||
| // | ||
| // @TODO: Is there a more efficient way than decoding the entry to access |
There was a problem hiding this comment.
Yes! You can use entry_and_operation.seq_num() ;-p
Right now, that actually just decodes the entry under-the-hood... but that is because we have a rather inefficient implementation of AsStorageEntry which we can improve later with a small amount of effort.
Comment on lines
+254
to
+258
| // The test runner creates a test entry for us, we can retreive the public key from the | ||
| // author | ||
| let public_key: Author = db | ||
| .test_data | ||
| .key_pairs | ||
| .first() | ||
| .unwrap() | ||
| .public_key() | ||
| .to_owned() | ||
| .try_into() | ||
| .unwrap(); |
There was a problem hiding this comment.
This is so ugly... 🤣 I think we need some more conversion traits for Author.
adzialocha
force-pushed
the
refactor-replication-api
branch
from
1da94dc
to
464716f
Compare
adzialocha
added a commit
that referenced
this pull request
Jul 1, 2022
* main: Update CHANGELOG.md Refactor replication API (#184) GraphQL replication client (#137) Update aquadoggo to v0.3.0 in aquadoggo_cli v0.3.0 Prepare CHANGELOG for v0.3.0 release Commit Cargo.lock p2panda-rs v0.4.0 Remove unused import Update naming in `publishEntry` query and `nextEntryArgs` response (#181) Fix bug when materialising documents containing (non-existent) pinned relations (#177) Logging in reduce task (#175) Refactor test db creation (#176)
adzialocha
added a commit
that referenced
this pull request
Jul 1, 2022
* schema-provider: Minor clean ups Move to unreleased section in CHANGELOG Update CHANGELOG.md Refactor replication API (#184) GraphQL replication client (#137) Update aquadoggo to v0.3.0 in aquadoggo_cli v0.3.0 Prepare CHANGELOG for v0.3.0 release Commit Cargo.lock p2panda-rs v0.4.0 Remove unused import Update naming in `publishEntry` query and `nextEntryArgs` response (#181) Fix bug when materialising documents containing (non-existent) pinned relations (#177)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Replication API:
EntryArgsRequestandPublishEntryRequestintodbmodule as it is more a struct used to query the database than an actual GraphQL thingContext:ReplicationContexthas been removed in favor of accessing already existingSqlStoragegraphql-clientwith simplergql-client, removes need of external.graphqlfiles,bingenerator and auto-generated typesautomockby replacing it withrstestmocking approachreplicationas they should be used both byclientandreplicationLogIdandSeqNumas strings are moved directly next to the regarding scalar implementationsDepends on #137
Closing #180 and #182 and #120
📋 Checklist
CHANGELOG.md