Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load DocumentId to be able to resolve it in meta field query #258

Merged
merged 2 commits into from
Sep 3, 2022

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Sep 2, 2022

Closes #253

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #258 (3c53b1d) into main (0bf77f5) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   94.00%   93.99%   -0.02%     
==========================================
  Files          59       59              
  Lines        4924     4928       +4     
==========================================
+ Hits         4629     4632       +3     
- Misses        295      296       +1     
Impacted Files Coverage Δ
aquadoggo/src/graphql/client/dynamic_query.rs 91.18% <80.00%> (-0.26%) ⬇️
.../src/graphql/client/dynamic_types/document_meta.rs 80.95% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@sandreae sandreae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@sandreae sandreae merged commit ce71ae7 into main Sep 3, 2022
@adzialocha adzialocha deleted the fix-document-id-meta branch September 3, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta field documentId in GraphQL query returns nothing
2 participants