Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce autonat and relay network protocols #314

Merged
merged 49 commits into from
Apr 13, 2023
Merged

Introduce autonat and relay network protocols #314

merged 49 commits into from
Apr 13, 2023

Conversation

mycognosist
Copy link
Contributor

@mycognosist mycognosist commented Mar 28, 2023

Addresses #306

  • Add configuration options for autonat
  • Add configuration options for relay
  • Expose autonat configuration options via CLI
  • Expose relay configuration options via CLI
  • Add the autonat network behaviour / protocol
    • Handle autonat::Event::StatusChanged events
    • Handle all other autonat events with catch-all logging
  • Add the relay network behaviour / protocol
    • Handle client and server events with catch-all logging
  • Refactoring
    • Move transport builder into separate module
    • Move swarm builder into separate module
  • Improve log-level stratification

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@mycognosist mycognosist marked this pull request as draft March 28, 2023 06:26
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 41.25% and project coverage change: -0.59 ⚠️

Comparison is base (57cdc6e) 89.88% compared to head (a512e9a) 89.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   89.88%   89.29%   -0.59%     
==========================================
  Files          66       68       +2     
  Lines        4942     5027      +85     
==========================================
+ Hits         4442     4489      +47     
- Misses        500      538      +38     
Impacted Files Coverage Δ
aquadoggo/src/graphql/mutations/publish.rs 100.00% <ø> (ø)
aquadoggo/src/graphql/queries/next_args.rs 97.43% <ø> (ø)
aquadoggo/src/network/config.rs 100.00% <ø> (ø)
aquadoggo/src/network/service.rs 15.23% <6.94%> (-7.85%) ⬇️
aquadoggo/src/network/transport.rs 36.84% <36.84%> (ø)
aquadoggo/src/network/behaviour.rs 59.09% <61.53%> (+1.02%) ⬆️
aquadoggo/src/graphql/queries/all_documents.rs 100.00% <100.00%> (ø)
aquadoggo/src/graphql/queries/document.rs 100.00% <100.00%> (ø)
aquadoggo/src/graphql/scalars/cursor_scalar.rs 57.14% <100.00%> (+9.77%) ⬆️
...quadoggo/src/graphql/scalars/document_id_scalar.rs 87.50% <100.00%> (+8.92%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mycognosist mycognosist marked this pull request as ready for review March 31, 2023 07:47
Copy link
Member

@sandreae sandreae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks really great! I had a few questions to help my understanding but no concrete change requests.

aquadoggo/Cargo.toml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
aquadoggo/src/network/config.rs Show resolved Hide resolved
aquadoggo/src/network/service.rs Show resolved Hide resolved
aquadoggo/src/network/service.rs Show resolved Hide resolved
aquadoggo/src/network/swarm.rs Show resolved Hide resolved
aquadoggo/src/network/transport.rs Outdated Show resolved Hide resolved
@mycognosist
Copy link
Contributor Author

Alrighty @sandreae , I reckon this should be good for a final check and mergeski.

@sandreae sandreae merged commit 66926fd into main Apr 13, 2023
@adzialocha adzialocha deleted the add_relay branch April 13, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants