Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by document id by default for root queries #352

Merged
merged 4 commits into from
May 2, 2023
Merged

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Apr 27, 2023

Closes #351

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (caf6bfb) 90.23% compared to head (27ea0aa) 90.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   90.23%   90.24%   +0.01%     
==========================================
  Files          70       70              
  Lines        6175     6174       -1     
==========================================
  Hits         5572     5572              
+ Misses        603      602       -1     
Impacted Files Coverage Δ
aquadoggo/src/db/query/order.rs 100.00% <ø> (ø)
aquadoggo/src/graphql/resolvers.rs 90.76% <100.00%> (ø)
aquadoggo/src/graphql/utils.rs 59.31% <100.00%> (+0.40%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adzialocha adzialocha marked this pull request as ready for review April 27, 2023 10:07
* main:
  Remove duplicate `Cursor` implementation, query code clean up (#346)
  Fix SQL ordering to correctly assemble resulting rows to documents (#347)
@adzialocha adzialocha merged commit d4a8a18 into main May 2, 2023
8 checks passed
@adzialocha adzialocha deleted the default-order-sql branch May 2, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set order default of collection query to document id
1 participant