Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate Cursor implementation, query code clean up #346

Merged
merged 7 commits into from
Apr 28, 2023

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Apr 26, 2023

Closes #344

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 86.20% and project coverage change: +0.02 🎉

Comparison is base (9c9a31f) 90.65% compared to head (ca988b4) 90.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   90.65%   90.68%   +0.02%     
==========================================
  Files          74       74              
  Lines        6423     6417       -6     
==========================================
- Hits         5823     5819       -4     
+ Misses        600      598       -2     
Impacted Files Coverage Δ
aquadoggo/src/db/mod.rs 91.66% <ø> (ø)
aquadoggo/src/db/query/order.rs 100.00% <ø> (ø)
aquadoggo/src/db/query/pagination.rs 84.61% <ø> (ø)
aquadoggo/src/db/query/select.rs 96.77% <ø> (ø)
aquadoggo/src/db/query/validate.rs 87.87% <ø> (+1.01%) ⬆️
aquadoggo/src/graphql/scalars/cursor_scalar.rs 73.33% <75.00%> (+15.43%) ⬆️
aquadoggo/src/db/stores/query.rs 94.65% <88.88%> (-0.24%) ⬇️
aquadoggo/src/db/query/filter.rs 90.94% <100.00%> (ø)
aquadoggo/src/graphql/utils.rs 58.91% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adzialocha adzialocha marked this pull request as ready for review April 26, 2023 16:08
@sandreae sandreae merged commit caf6bfb into main Apr 28, 2023
@adzialocha adzialocha deleted the graphql-cleanup branch April 28, 2023 22:57
adzialocha added a commit that referenced this pull request May 2, 2023
* main:
  Remove duplicate `Cursor` implementation, query code clean up (#346)
  Fix SQL ordering to correctly assemble resulting rows to documents (#347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate cursor trait implementation
2 participants