Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse lookup for pinned relations in dependency task #434

Merged
merged 13 commits into from
Jul 5, 2023

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Jul 3, 2023

See diagram for more details: https://whimsical.com/materializer-DbV6FUs51pqhouKff7Q546

Closes: #418 and #411 and #152

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@adzialocha adzialocha force-pushed the inverse-relations-materialisation branch from 282f80d to 5692caa Compare July 3, 2023 15:24
@adzialocha adzialocha changed the title Inverse relations materialisation Reverse lookup for pinned relations in dependency task Jul 3, 2023
@adzialocha adzialocha marked this pull request as ready for review July 3, 2023 21:37
@adzialocha adzialocha requested a review from sandreae July 3, 2023 21:49
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 96.06% and project coverage change: +0.20 🎉

Comparison is base (4c38eb6) 89.87% compared to head (492f965) 90.08%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #434      +/-   ##
===============================================
+ Coverage        89.87%   90.08%   +0.20%     
===============================================
  Files               87       87              
  Lines             8245     8439     +194     
===============================================
+ Hits              7410     7602     +192     
- Misses             835      837       +2     
Impacted Files Coverage Δ
aquadoggo/src/db/models/utils.rs 99.44% <ø> (ø)
aquadoggo/src/test_utils/node.rs 100.00% <ø> (ø)
aquadoggo/src/materializer/tasks/reduce.rs 88.78% <73.52%> (-2.20%) ⬇️
aquadoggo/src/materializer/tasks/dependency.rs 98.76% <99.54%> (+0.54%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sandreae sandreae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good except for one point I commented on.

aquadoggo/src/materializer/tasks/dependency.rs Outdated Show resolved Hide resolved
aquadoggo/src/materializer/tasks/dependency.rs Outdated Show resolved Hide resolved
@adzialocha adzialocha requested a review from sandreae July 4, 2023 15:02
@adzialocha adzialocha merged commit ae27ff2 into development Jul 5, 2023
8 checks passed
@adzialocha adzialocha deleted the inverse-relations-materialisation branch July 5, 2023 08:38
adzialocha added a commit that referenced this pull request Jul 14, 2023
* development: (23 commits)
  Implement `dialer` behaviour (#444)
  Sort expected results in strategy tests
  Update CHANGELOG
  Replicate operations in topo order (#442)
  Maintain sorted operation indexes (#438)
  Use fork of `asynchronous-codec`  (#440)
  Ingest check for duplicate entries (#439)
  Reverse lookup for pinned relations in dependency task (#434)
  Remove unnecessary exact version pinning in Cargo.toml
  Make `TaskInput` an enum and other minor clean ups in materialiser (#429)
  Use `libp2p` `v0.52.0` (#425)
  Fix race condition when check for existing view ids was too early (#420)
  Reduce logging verbosity
  CI: Temporary workaround for Rust compiler bug (#417)
  Fix early document view insertion (#413)
  Handle duplicate document view insertions (#410)
  Decouple p2panda's authentication data types from libp2p's (#408)
  Remove dead_code attribute in lib
  Integrate replication manager with networking stack (#387)
  Implement naive replication protocol (#380)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants