Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: dedup generated schema fields by key #558

Merged
merged 10 commits into from
Sep 8, 2023
Merged

Fix: dedup generated schema fields by key #558

merged 10 commits into from
Sep 8, 2023

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Sep 8, 2023 •
edited

Fixes a logic error in the proptests which was causing intermittent test failures. And a refactor so test regressions go into named files per test.

closes: #520 #459

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@sandreae sandreae linked an issue Sep 8, 2023 that may be closed by this pull request
Prop tests false-failure case #459
Closed
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited

Codecov Report

Patch and project coverage have no change.

Comparison is base (6b13189) 92.45% compared to head (ebb7274) 92.46%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   92.45%   92.46%           
=======================================
  Files         106      106           
  Lines       18039    18039           
=======================================
+ Hits        16678    16679    +1     
+ Misses       1361     1360    -1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@sandreae sandreae merged commit 4a2c34c into main Sep 8, 2023
10 checks passed
@sandreae sandreae deleted the fix-prop-test-regressions branch September 8, 2023 12:42
adzialocha added a commit that referenced this pull request Sep 19, 2023
@adzialocha
Merge branch 'main' into improve-network-config
2ca0746 
* main:
  Update version in Cargo.lock as well
  Do not panic when blob does not have all pieces yet (#563)
  Make cli version reflect the crate version
  One hash is enough when releasing binaries
  Remove unused methods from `EntryStore` (#560)
  Fix: dedup generated schema fields by key (#558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proptests failure case: invalid field type Prop tests false-failure case
1 participant
@sandreae