Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let document subscription stream updates from materializer #605

Draft
wants to merge 3 commits into
base: pv/subscriptions
Choose a base branch
from

Conversation

cafca
Copy link
Member

@cafca cafca commented Dec 9, 2023

Best reviewed commit by commit

The subscription field for receiving updates about a specific document is updated to trigger sending a new update whenever the materializer finishes a new version of it.

This required changing up the message bus and service manager a bit to allow receiving updates about newly updated documents from within the http service. Context receives a new field containing the service sender, which is now constructed outside the service manager and passed in to it as a parameter.

Then, a new message type DocumentUpdated is added, which is emitted in the reducer task whenever documents are created or updated. This lets use then connect any running subscription stream to the service bus and listen for updates of their queried document.

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@cafca cafca mentioned this pull request Dec 9, 2023
4 tasks
@sandreae
Copy link
Member

sandreae commented Jan 9, 2024

This is already looking good 🙏 🙏 🙏 ! Is there any more functionality you want to include?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants