Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete sighting #106

Merged
merged 11 commits into from
May 31, 2024
Merged

Delete sighting #106

merged 11 commits into from
May 31, 2024

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented May 30, 2024

  • delete sighting with new popup button on sighting screen
  • confirm action
  • navigate back to all sightings after deletion
  • show message in snackbar
  • Make sure that all sightings list is refreshed

@sandreae sandreae linked an issue May 30, 2024 that may be closed by this pull request
@sandreae sandreae requested a review from adzialocha May 30, 2024 13:39
@adzialocha
Copy link
Member

Do you mind me having a go on the position and design of the button? It might be too prominent and too kind looking for a destructive action?

@sandreae
Copy link
Member Author

Do you mind me having a go on the position and design of the button? It might be too prominent and too kind looking for a destructive action?

Please do! (I was hoping someone would 😏 )

@adzialocha
Copy link
Member

adzialocha commented May 30, 2024

I've did a couple of changes:

  1. The sighting view can be opened from the "Species Profile" view and from the "All Sightings" view, to account for both cases and keep the history intact (use the system back-button to test) I've changed the router to pop from the stack instead
  2. Added logic to refresh widgets when returning from deletion
  3. Replaced button with a "more" menu in top right corner of app bar
  4. Changed labels in dialog to "Cancel" and "Delete" to make actions more clear

Also delete all associated uses and location documents

Continued here: #108

Copy link
Member Author

@sandreae sandreae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot with the navigation changes w/ refreshing, definitely less tempting to delete sightings with the dropdown menu now.

@sandreae sandreae merged commit 65b0ceb into main May 31, 2024
@adzialocha adzialocha deleted the delete-sighting branch May 31, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete sighting
2 participants