Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boost download and compilation before use it #4

Closed
vicente-gonzalez-ruiz opened this issue Mar 6, 2017 · 8 comments
Closed

Add Boost download and compilation before use it #4

vicente-gonzalez-ruiz opened this issue Mar 6, 2017 · 8 comments
Labels

Comments

@vicente-gonzalez-ruiz
Copy link
Member

There is a problem using Boost from the package repositories in some OS (for example, Ubuntu 16.04.2 LTS). We think that a good solution could be to include in the file make.py an option to compile p2psp-console using downloaded (and compiled) version of Boost. The compilation of Boost could be stored in a temporal directory inside p2psp-console.

@anu1097
Copy link

anu1097 commented Mar 6, 2017

The compiled binary version of boost can be downloaded from here https://sourceforge.net/projects/boost/files/boost-binaries/. But after putting it in a separate directory in p2psp-console how do we link it in make.py ?

@vicente-gonzalez-ruiz
Copy link
Member Author

vicente-gonzalez-ruiz commented Mar 6, 2017

Hi @anu1097 . Thanks for working in this issue. Two comments: (1) I think that it is preferable that we download the source and compile it, and (2) if I'm not wrong, it is possible to indicate to cmake where is Boost through the CMakeLists.txt commands:

set(BOOST_ROOT "/usr/local/boost_1_59_0")
set(Boost_NO_SYSTEM_PATHS TRUE)
set(BOOST_INCLUDEDIR "/usr/local/boost_1_59_0/include")
set(BOOST_LIBRARYDIR "/usr/local/boost_1_59_0/stage/lib")

where /usr/local/boost_1_59_0 is the path to the downloaded (and compiled) Boost (don't use this version, use the last one).

But, notice that we don't want to add this stuff to this file. We prefer to manage all this only using make.py.

Thanks!

@abhay44
Copy link

abhay44 commented Mar 7, 2017

@vicente-gonzalez-ruiz You want to download and compile the whole boost libraries using make.py? am I correct?

@vicente-gonzalez-ruiz
Copy link
Member Author

vicente-gonzalez-ruiz commented Mar 7, 2017

@abhay44, right. If we download a compiled Boost we run the risk of getting the same errors :-/

@abhay44
Copy link

abhay44 commented Mar 8, 2017

@vicente-gonzalez-ruiz there are lot of boost libraries and the compilation takes more time if we manually download and compile them.Is it ok? or do we have other option?

@vicente-gonzalez-ruiz
Copy link
Member Author

vicente-gonzalez-ruiz commented Mar 9, 2017

Hi @abhay44 . Check P2PSP/core#127

@abhay44
Copy link

abhay44 commented Mar 10, 2017

@vicente-gonzalez-ruiz I think we can close this issue. Fixed in P2PSP/core#127.

@vicente-gonzalez-ruiz
Copy link
Member Author

Right. Please, do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants