Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Boost download, compilation before using it #127

Merged
merged 2 commits into from
Mar 9, 2017

Conversation

abhay44
Copy link
Contributor

@abhay44 abhay44 commented Mar 8, 2017

@vicente-gonzalez-ruiz I automated the download and compilation process as you suggested and user can use the new downloaded Boost libraries rather than system libraries. The compilation runs fine, but I get some CMake warnings(link). I think the reason why we get these warnings is because system has old libraries.Apart from that all the automation works fine.

@vicente-gonzalez-ruiz
Copy link
Member

Hi @abhay44. Loads of thanks for our PR! However, I have a final request. We would like that this new functionality where optional. The steps would be: (1) download boost from the OS's repository and P2PSP core from GutHub, (2) compile the core with make.py and if the compilation fails, (3) the user try again the compilation of everything with the functionality you have included in your PR. So, could you include a command-line parameter in make.py indicating that the user wants to compile against the downloaded copy of Bosst from sourceforge. Thanks!

@vicente-gonzalez-ruiz
Copy link
Member

A note: please, include --no-check-certificate to the wget (it can fail in some situations).

@vicente-gonzalez-ruiz
Copy link
Member

Another comment: please, check whether the Boost has been previously downloaded (make.py always download Boost, even if it has been downloaded just before). Thanks!

@abhay44
Copy link
Contributor Author

abhay44 commented Mar 9, 2017

@vicente-gonzalez-ruiz Updated!! Is this what you want to have?

@vicente-gonzalez-ruiz
Copy link
Member

@abhay44 . Your PR works perfectly. As said before, thank you!

@vicente-gonzalez-ruiz vicente-gonzalez-ruiz merged commit bbada81 into P2PSP:master Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants