Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor: typescript #1382

Merged
merged 72 commits into from
Jun 11, 2024
Merged

♻️ refactor: typescript #1382

merged 72 commits into from
Jun 11, 2024

Conversation

maximedasilva
Copy link
Member

No description provided.

renovate bot and others added 30 commits April 8, 2024 14:50
…-pages-5.x

chore(deps): update actions/configure-pages action to v5 (develop)
…ction-4.x

chore(deps): update codecov/codecov-action action to v4.3.0 (develop)
…-monorepo

chore(deps): update dependency @typescript-eslint/parser to v7.11.0 (develop)
Copy link

naming-cop bot commented Jun 7, 2024

I've found one or more issues in this PR:

refactor): use _objet_ only inside react package (0813974)

  • ❌ subject may not be empty
  • ❌ type may not be empty

Happy coding!

@dackmin
Copy link
Member

dackmin commented Jun 7, 2024

@naming-cop stfu

Copy link

naming-cop bot commented Jun 7, 2024

Okay I will now shut up.

@dackmin dackmin marked this pull request as ready for review June 7, 2024 13:34
@dackmin dackmin changed the title ♻️refactor: typescript - core package ♻️ refactor: typescript Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.47%. Comparing base (f8377ab) to head (84f81f4).

Current head 84f81f4 differs from pull request most recent head a975e97

Please upload reports for the commit a975e97 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1382   +/-   ##
=======================================
  Coverage   55.47%   55.47%           
=======================================
  Files          38       38           
  Lines        1761     1761           
  Branches      544      544           
=======================================
  Hits          977      977           
  Misses        705      705           
  Partials       79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dackmin dackmin merged commit 4f1f530 into master Jun 11, 2024
3 of 4 checks passed
@dackmin dackmin deleted the refactor/typescript branch June 11, 2024 08:01
@dackmin dackmin restored the refactor/typescript branch June 19, 2024 08:22
@dackmin dackmin deleted the refactor/typescript branch June 19, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants