Deprecate temporary P4DeviceConfig message #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, in favour of this change... Took us a whole day to find out that this P4DeviceConfig construct was needed when prototyping p4runtime solutions😢 |
The assumption was always that this was a temporary message. It was required when using bmv2 simple_switch, but is no longer needed with simple_switch_grpc. As a result of this change, the ForwardingPipelineConfig::p4_device_config binary string is passed on directly to PI. For backward compatibility, the DeviceMgr still tests whether this field is a serialized P4DeviceConfig message (and behaves as before).
antoninbas
force-pushed
the
antonin/deprecate-P4DeviceConfig
branch
from
4bfabed
to
8572928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assumption was always that this was a temporary message. It was
required when using bmv2 simple_switch, but is no longer needed with
simple_switch_grpc.
As a result of this change, the
ForwardingPipelineConfig::p4_device_config binary string is passed on
directly to PI. For backward compatibility, the DeviceMgr still tests
whether this field is a serialized P4DeviceConfig message (and behaves
as before).