Remove unncessary v1model include in P4 test programs - fix up programs that use v1model externs. #3608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
changed the title
mihaibudiu
approved these changes
Oct 24, 2022
pkotikal
approved these changes
Oct 25, 2022
fruffy
force-pushed
the
remove_v1model
branch
from
3810005
to
ad17941
Compare
jafingerhut
reviewed
Oct 25, 2022
| @@ -1,6 +1,7 @@ | |||
| #include <core.p4> | |||
| #define V1MODEL_VERSION 20180101 | |||
There was a problem hiding this comment.
I admit I am a bit fuzzy on this V1MODEL_VERSION variable that was used here, and do not know how to check whether removing it is a good idea or a bad idea in the test programs where you have removed it. Any advice you might provide on helping guide my thinking about when this V1MODEL_VERSION is supposed to be used, vs. not?
There was a problem hiding this comment.
I believe this variable is added automatically by toP4 here whenever v1model.p4 is included.
jafingerhut
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #3606 for ref files. Fixes #3517. Instead of converting all of the programs to v1model this PR only converts the programs that use v1model externs.