-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for string roles & roles in reads #346
Conversation
Antonin, I just got the tests to pass. Can you review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you squash the commits and include the following in the commit message body:
Fixes #344
Fixes #345
It will link the PR to these issues properly and close them automatically when the PR is merged. Thanks.
I squashed the commits. |
@konne-google you have merged conflicts, as I had to merge a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@antoninbas , I don't think I can merge the request (The base branch restricts merging to authorized users.), could you do it for me? There is still a failing test, but I don't think I can fix it, it says: docker: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit. |
@konne88 I restarted the job, I'll merge when it passes |
This addresses bugs:
#344
#345