Add support for string roles & roles in reads #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Antonin, I just got the tests to pass. Can you review. Thanks! |
stolsma
reviewed
Apr 21, 2021
stolsma
reviewed
Apr 21, 2021
antoninbas
reviewed
Apr 21, 2021
|
I squashed the commits. |
|
@konne-google you have merged conflicts, as I had to merge a separate PR |
|
@antoninbas , I don't think I can merge the request (The base branch restricts merging to authorized users.), could you do it for me? There is still a failing test, but I don't think I can fix it, it says: docker: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit. |
|
@konne88 I restarted the job, I'll merge when it passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses bugs:
#344
#345