Pluggable packet module proposal #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, packet module will be pluggable, as it will try do dynamically import an implementation specified in config or provided as an argument. In that way PTF will become independent regarding Scapy, since one can develop his/her own packet manipulation framework and then create an implementation of packet module for it. By default it will be Scapy.
|
Can you provide some examples, how we should use it with |
NexSabre
reviewed
Aug 21, 2021
Yi-Tseng
reviewed
Aug 30, 2021
NexSabre
reviewed
Aug 31, 2021
Addressed community review - Added short (-pmm) arg option - Provided some description in README.md - Added default value for packet manipulation module in generic packet module - Removed scapy from requirements.txt as it is now optional, if custom packet manipulation module is provided - Removed alias 'scapy' from testutils
Yi-Tseng
approved these changes
Nov 9, 2021
|
ATM I'm testing this solution internally, as 'test' pipeline cannot be run yet. @antoninbas would you mind looking at these proposal? |
* Add hexdump symbol to packet module Also, modified mask module to not call Scapy directly. * Increase verbosity when choosing PMM * Deprecate set_do_not_care_scapy Now please use set_do_not_care_packet instead.
NexSabre
suggested changes
Nov 18, 2021
| @@ -84,14 +90,14 @@ def __str__(self): | |||
|
|
|||
|
|
|||
| def utest(): | |||
There was a problem hiding this comment.
This test can be transferred to a separate module (test), it is not needed here. Instead, you can add a short comment to the class
* Changes in dataplane to become scapy independent * Fix name for ERSPAN platform specific in testutils
antoninbas
reviewed
Nov 29, 2021
According to antoninbas's review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, packet module will be pluggable, as it will try do dynamically
import an implementation specified in config or provided as an argument.
In that way PTF will become independent regarding Scapy, since one can
develop his/her own packet manipulation framework and then create an
implementation of packet module for it. By default it will be Scapy.