Addressed community review #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added short (-pmm) arg option - Provided some description in README.md - Added default value for packet manipulation module in generic packet module - Removed scapy from requirements.txt as it is now optional, if custom packet manipulation module is provided
hkrasnod
reviewed
Oct 29, 2021
hkrasnod
reviewed
Oct 29, 2021
hkrasnod
reviewed
Oct 29, 2021
README.md
Outdated
| ## Pluggable packet manipulation module | ||
|
|
||
| By default, `ptf` uses `Scapy` as a packet manipulation module, but now it | ||
| can operate on other, custom one. To use other packet manipulation module, |
There was a problem hiding this comment.
on another one ??? It sounds kind of general.
There was a problem hiding this comment.
Another thing is that this is a README file not release notes - this should describe current state not diff.
There was a problem hiding this comment.
This is inside of section New features, but I can adjust this section to be more as a current state 👍
There was a problem hiding this comment.
I wonder if somebody removes features from New features section :)
hkrasnod
reviewed
Oct 29, 2021
README.md
Outdated
| one needs to provide it as an argument `-pmm` or | ||
| `--packet-manipulation-module` when running `ptf` binary. | ||
|
|
||
| In order to make it work, such module must implement methods, as defined in |
There was a problem hiding this comment.
It would be great to describe or provide a minimal working example because now it's not easy to determine what needs to be implemented.
hkrasnod
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module
packet manipulation module is provided