Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pa11y-ci error output not as descriptive as pa11y error output #64

Open
dominicfraser opened this issue Jul 24, 2018 · 4 comments
Open

Comments

@dominicfraser
Copy link

As first noted as a comment in issue 60:

pally-ci does not output the specific guides that fail in the same way pa11y does, instead just a suggestion of how to fix. This means if you want to ignore one rather than fix it then it takes additional research to find out what it is.

Specifically, this was painful when having to search through pa11y issues to discover that WCAG2AA.Principle1.Guideline1_4.1_4_3.G18 is actually added as an ignored rules of WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail - whereas in pa11y main it lists the exact code that fails.

Would it be possible to output the ones that fail, as they are not always exactly the same (as proven) in the list of CodeSniffer Rules?

An example ignore list:

"ignore": [
          "WCAG2AA.Principle2.Guideline2_4.2_4_2.H25.1.NoTitleEl",
          "WCAG2AA.Principle3.Guideline3_1.3_1_1.H57.2",
          "WCAG2AA.Principle1.Guideline1_4.1_4_3.G145.Fail",
          "WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail"
        ],
@amack459
Copy link

I'm having the same issue. Is it possible to have a more verbose fail messages option for pa11y-ci like those in pa11y?

@synterra
Copy link

@dominicfraser where did you learn that the rule name had the .Fail at the end, as in WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail and not WCAG2AA.Principle1.Guideline1_4.1_4_3.G18 as it's listed on the CodeSniffer rules?

I'm trying to find an equivalent for the WCAG2AA.Principle4.Guideline4_1.4_1_1.F77 rule (duplicate IDs, an issue sometimes with Drupal) and can't get pa11y-ci to ignore those errors.

@dominicfraser
Copy link
Author

It was pure chance unfortunately, searching around issues and finding someone who mentioned using .Fail -> I tried it on that rule and it also worked!

@aarongoldenthal
Copy link
Contributor

For the cases where warnings or notices are included, the pa11y-ci output also doesn't distinguish between types, unlike the pa11y output.

aarongoldenthal added a commit to aarongoldenthal/pa11y-ci that referenced this issue Aug 24, 2020
…a11y#64)

Replace chalk with kleur as a lighter alternative, and consistent with
pa11y-reporter-cli.   To remove duplication, and get console output
consistent with pa11y, leverage pa11y-reporter-cli for detailed results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants