Replace chalk with kleur #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a11y#64) Replace chalk with kleur as a lighter alternative, and consistent with pa11y-reporter-cli. To remove duplication, and get console output consistent with pa11y, leverage pa11y-reporter-cli for detailed results.
| "lodash": "~4.17.20", | ||
| "node-fetch": "~2.6.0", | ||
| "pa11y": "~5.3.0", | ||
| "pa11y-reporter-cli": "~2.0.0", |
There was a problem hiding this comment.
Question for @pa11y/pa11y-reviewers, any idea why pa11y-ci didn't use the reporter before?
*for the record, I think using the reporter here is a great idea!
|
Released as part of v3.0.0, thanks for the PR @aarongoldenthal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
chalkwithkleur(#109), chosen for consistency withpa11y-reporter-cli. It also leveragespa11y-reporter-clifor detailed scan result output, which eliminates a significant amount of formatting code, and makes the console output consistent withpa11y(#64).Two additional notes:
versionproperty inpackage-lock.json(whichnpm caught when changing dependencies)wordwrapwas removed since the applicable output is now all generated withpa11y-reporter-cli, but it does not wrap