Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js support to 18-20 from 12-16, dependencies, documentation, some practices #19

Merged
merged 31 commits into from
Oct 11, 2023

Conversation

danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Oct 5, 2023

This PR if it passes review will require a major version update. I've mentioned "version 4" in a couple of places in anticipation. It:

  1. makes the CI workflow pass again
  2. updates Node.js support to 14-20 18-20 from 12-16
  3. upgrades dependencies and native actions to latest; some of this was required for (1)
  4. fixes circular dependency warnings when testing locally
  5. fixes some references to older naming of this package
  6. minor refactoring and fixes for documentation and code
  7. quietly adds (or just acquires, with the updates) support for nektos/act; I'll add a paragraph to the readme about this in a future PR

More detail in commit log and will summarise here:

  1. Dependency upgrades:
    1. Sinon upgrade was required to resolve circular dependency warnings involving fakeServer
    2. Mockery's major upgrade did not involve an API change, so should be ok
    3. Grunt doesn't require a global installation any more and I've removed that advice from the readme
    4. JSHint config has been updated a bit to latest spec, but other parts of that object may still be outdated and have no effect
  2. removed unused Grunt task grunt ci; we could consider removing Grunt completely in a future PR
  3. push will now trigger on both master and main in preparation for renaming the default branch
  4. GitHub Actions workflow names etc were trimmed where their meaning was already represented well by their function

.github/workflows/tests.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
Gruntfile.js Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@danyalaytekin danyalaytekin marked this pull request as ready for review October 6, 2023 11:53
@danyalaytekin danyalaytekin changed the title [WIP] Update Node.js support to 14-20 from 12-16, dependencies, documentation, some practices Update Node.js support to 14-20 from 12-16, dependencies, documentation, some practices Oct 6, 2023
@danyalaytekin
Copy link
Member Author

danyalaytekin commented Oct 6, 2023

@josebolos Perhaps I could have forgone retaining Node 14 support, following @aarongoldenthal's lead in pa11y/pa11y#664, since it has passed EOL, even if it still passes in CI. Node 16 also reached EOL on September 11th 2023. What do you think?

@josebolos
Copy link
Member

@josebolos Perhaps I could have foregone retaining Node 14 support, following @aarongoldenthal's lead in pa11y/pa11y#664, since it has passed EOL, even if it still passes in CI. Node 16 also reached EOL on September 11th 2023. What do you think?

Agreed! I think that we should only support currently supported LTS versions, so I would remove support for anything that is not Node 18 or 20 from every repo.

README.md Outdated Show resolved Hide resolved
@danyalaytekin
Copy link
Member Author

remove support for anything that is not Node 18 or 20 from every repo

@josebolos Done for this repo, noted for others! I've also removed the advice to use npm 8+ since npm 8 comes with Node 18.

84c7ec9

@danyalaytekin danyalaytekin changed the title Update Node.js support to 14-20 from 12-16, dependencies, documentation, some practices Update Node.js support to 18-20 from 12-16, dependencies, documentation, some practices Oct 6, 2023
@danyalaytekin danyalaytekin dismissed josebolos’s stale review October 9, 2023 09:54

Removed section and added issue for discussion to pa11y/org

Copy link
Member

@josebolos josebolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danyalaytekin danyalaytekin merged commit 31bed98 into main Oct 11, 2023
2 checks passed
@danyalaytekin danyalaytekin deleted the spring-clean branch October 11, 2023 14:14
@danyalaytekin danyalaytekin added this to the 4.0.0 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants