This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Fixes mfncooper/mockery #51 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each mock in the hookedLoader cache, on disable or reset, remove it from its parent's children list.
|
This looks ok to me and all the tests pass :) I'll make this a major version bump just to be safe.. |
|
Published in |
carlosvillademor
added a commit
to carlosvillademor/mockery
that referenced
this pull request
Jun 19, 2017
This is to prevent the disable method to fail if there is anything on the require cache object that does not have a parent element or children on that parent object. This fixes a problem introduced on PR mfncooper#57
carlosvillademor
added a commit
to carlosvillademor/mockery
that referenced
this pull request
Jun 19, 2017
This is to prevent the disable method to fail if there is anything on the require cache object that does not have a parent element or children on that parent object. This fixes a problem introduced on PR mfncooper#57
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #51.
For each mock in the hookedLoader cache, on disable
or reset, remove it from its parent's children list.
This gets rid of the leak in our test suite, which is relatively larges (1100 specs, each one attempting to use a clean mockery cache). I'm by no means an expert on the node module API though, so it's possible that I did something dumb here.