Add Windows and macOS to the test matrix #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node v18 just came out a few days ago, and v12 is going to be unsupported as of next week. This updates the test matrix accordingly.
danyalaytekin
pushed a commit
that referenced
this pull request
Oct 9, 2023
* Add windows and macos to the test matrix * Set test-specific environment variables within jest setup * Fix handling of absolute paths in Windows * Fix Windows path issues in htmlcs tests * Fix issues with absolute paths in Windows * Move env var to global since needed there and run before setup * Update path resolution to be platform independent * Update cli runner to call node since Windows ignores the shebang in bin * Clean up comment for clarity * Update comments to clarify behavior * Increase timeout for Mac tests timing out * Remove node 12 and add node 18 to test matrix Co-authored-by: Aaron Goldenthal <aaron.goldenthal@gmail.com>
danyalaytekin
changed the title
danyalaytekin
added a commit
that referenced
this pull request
Oct 11, 2023
* Add windows and macos to the test matrix (#647) * Add windows and macos to the test matrix * Set test-specific environment variables within jest setup * Fix handling of absolute paths in Windows * Fix Windows path issues in htmlcs tests * Fix issues with absolute paths in Windows * Move env var to global since needed there and run before setup * Update path resolution to be platform independent * Update cli runner to call node since Windows ignores the shebang in bin * Clean up comment for clarity * Update comments to clarify behavior * Increase timeout for Mac tests timing out * Remove node 12 and add node 18 to test matrix Co-authored-by: Aaron Goldenthal <aaron.goldenthal@gmail.com> * Fix references to `matrix.node-version` * Explain git config change as normalising line endings * Remove commentary which duplicates content * Rename job to `test` from `checkout_and_test` * Remove incorrect workflow name * Trigger on push to `main` to allow default branch to be renamed * Use briefer syntax for pull request trigger * Remove `master` as `push` trigger --------- Co-authored-by: Jose Bolos <josebolos@users.noreply.github.com> Co-authored-by: Aaron Goldenthal <aaron.goldenthal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.