Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support macOS and Windows (absorb next) #678

Merged
merged 9 commits into from Oct 11, 2023
Merged

Support macOS and Windows (absorb next) #678

merged 9 commits into from Oct 11, 2023

Conversation

danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Oct 9, 2023 •
edited

This PR merges the changes already present in next into the default branch, another step towards releasing pa11y@7.

Additional changes alongside those in next

  1. Supports push to main in preparation for next build on main when merged, part of:
    Rename the 8 default branches to main from master org#19
  2. Some renaming, and also removal of naming and comments where content was descriptive

Repo settings updates

  1. Require new jobs in matrix to pass
  2. Rename default branch to main from master

Changes arriving from next

By @aarongoldenthal and @josebolos in:

New arrivals

  1. Add Windows and macOS to GA matrix
  2. Set test-specific environment variables within Jest setup
  3. Move env var to global since needed there and run before setup
  4. Update path resolution to be platform independent, and fix issues
  5. Update cli runner to call node since Windows ignores the shebang in bin
  6. Increase timeout for Mac tests timing out

Already present in default branch

  1. Update Node.js support to 18, 20

@danyalaytekin danyalaytekin self-assigned this Oct 9, 2023
@josebolos @aarongoldenthal @danyalaytekin
Add windows and macos to the test matrix (#647)
89eb56f 
* Add windows and macos to the test matrix
* Set test-specific environment variables within jest setup
* Fix handling of absolute paths in Windows
* Fix Windows path issues in htmlcs tests
* Fix issues with absolute paths in Windows
* Move env var to global since needed there and run before setup
* Update path resolution to be platform independent
* Update cli runner to call node since Windows ignores the shebang in bin
* Clean up comment for clarity
* Update comments to clarify behavior
* Increase timeout for Mac tests timing out
* Remove node 12 and add node 18 to test matrix

Co-authored-by: Aaron Goldenthal <aaron.goldenthal@gmail.com>
@danyalaytekin danyalaytekin changed the title [WIP] Update platform support (absorb next) Support macOS and Windows (absorb next) Oct 9, 2023
@danyalaytekin danyalaytekin marked this pull request as ready for review October 9, 2023 13:01
josebolos
josebolos approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@josebolos josebolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@danyalaytekin danyalaytekin merged commit 15b8637 into main Oct 11, 2023
6 checks passed
@danyalaytekin danyalaytekin deleted the next branch October 11, 2023 14:09
@danyalaytekin danyalaytekin added this to the 7 milestone Nov 9, 2023
@danyalaytekin danyalaytekin mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josebolos josebolos josebolos approved these changes

Assignees

@danyalaytekin danyalaytekin

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danyalaytekin @josebolos