Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 fails to load #638

Closed
djbrown opened this issue Dec 22, 2022 · 4 comments
Closed

v3 fails to load #638

djbrown opened this issue Dec 22, 2022 · 4 comments
Assignees
Labels
duplicate This issue or pull request already exists

Comments

@djbrown
Copy link

djbrown commented Dec 22, 2022

I just upgraded from v3.0.0 to v3 which currently should be v3.2.0.
See commit djbrown/hbscorez@8cd9185#diff-68ba9d12f6f2601fe3c9f7f9d0d02aaea52384559d6d08fae7afc941663fdfcdR89 file .github/workflows/ci-build.yml Line 89
Before:

      - uses: paambaati/codeclimate-action@v3.0.0
        env:
          CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}

After:

      - uses: paambaati/codeclimate-action@v3
        env:
          CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}

But then my workflow step aborts with following error:

Download action repository 'paambaati/codeclimate-action@v3' (SHA:e5d7b870aec2c3faa8249ec2444850f153c6ccef)
Error: paambaati/codeclimate-action/v3/action.yml:
Error: paambaati/codeclimate-action/v3/action.yml: (Line: 30, Col: 51, Idx: 902) - (Line: 30, Col: 80, Idx: 931): While parsing a block mapping, did not find expected key.
Error: System.ArgumentException: Unexpected type '' encountered while reading 'action manifest root'. The type 'MappingToken' was expected.
   at GitHub.DistributedTask.ObjectTemplating.Tokens.TemplateTokenExtensions.AssertMapping(TemplateToken value, String objectDescription)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Fail to load paambaati/codeclimate-action/v3/action.yml

Just as in #430 (v3.0.0 fails to load)

@djbrown djbrown added the bug Something isn't working label Dec 22, 2022
@djbrown
Copy link
Author

djbrown commented Dec 22, 2022

I just rerun my workflow, but the problem still persists

@djbrown
Copy link
Author

djbrown commented Dec 22, 2022

The error message refers to the exact line, that was fixed in #432
I'll try to rerun with explicit v3.2.0

@djbrown djbrown changed the title v3.2.0 fails to load v3 fails to load Dec 22, 2022
djbrown added a commit to djbrown/hbscorez that referenced this issue Dec 22, 2022
@djbrown
Copy link
Author

djbrown commented Dec 22, 2022

So I just set the version explicitly to v3.2.0 and that works!
But the problem with v3 still persists.
Priority for me is lower now :) but I still looked into it.
the hash of the downloadad action points to e5d7b87 aka 3.1.0
the commit is from september 2021, but the version was released on october 2022.
"vX" should always resolve to the latest version. can you fix that or ask github whats wrong there?

@paambaati paambaati added duplicate This issue or pull request already exists and removed bug Something isn't working labels Dec 23, 2022
@paambaati
Copy link
Owner

Duplicate of #577

This action publishes only specific version tags, so v3 does not resolve to the latest version. This is more a convention that some projects follow and should not be a hard expectation.

This can possibly be fixed in v4.x.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants